Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Aqualung - media player with native jack support ans ladspa support https://bugzilla.redhat.com/show_bug.cgi?id=430366 ------- Additional Comments From guidolinfrancesco@xxxxxxxx 2008-02-02 16:00 EST ------- (This is an informal review) Version: 0.9beta9 Non numeric version string like alpha, beta, rc, cannot be simply putted into the version tag, you should use the Release field for this. http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a I think you should disable all the optional package that doesn't fill the Fedora guidelines, like ffmpeg, using the appropriate ./configure flags: --with-oss=yes,no compile with OSS support (default: yes) --with-alsa=yes,no compile with ALSA support (default: yes) --with-jack=yes,no compile with JACK support (default: yes) --with-src=yes,no compile with Sample Rate Converter support (default: yes) --with-sndfile=yes,no compile with sndfile (WAV, AIFF, etc.) support (default: yes) --with-flac=yes,no compile with FLAC support (default: yes) --with-ogg=yes,no compile with Ogg Vorbis support (default: yes) --with-vorbisenc=yes,no compile with Ogg Vorbis encoding support (default: yes) --with-speex=yes,no compile with Ogg Speex support (default: yes) --with-mpeg=yes,no compile with MPEG Audio support (default: yes) --with-mod=yes,no compile with MOD Audio support (default: yes) --with-mpc=yes,no compile with Musepack support (default: yes) --with-mac=yes,no compile with Monkey's Audio Codec support (default: yes) --with-lavc=yes,no compile with lavc (FFmpeg) support (default: yes) --with-lame=yes,no compile with LAME (MP3 encoding) support (default: yes) --with-wavpack=yes,no compile with WavPack support (default: yes) --with-ladspa=yes,no compile with LADSPA plugin support (default: yes) --with-cdda=yes,no compile with CDDA support (default: yes) --with-cddb=yes,no compile with CDDB support (default: yes) --with-ifp=yes,no compile with iRiver iFP driver support (default: yes) --with-systray=yes,no compile with Systray support (default: yes) --with-loop=yes,no compile with loop playback support (default: yes) --with-podcast=yes,no compile with podcast support (default: yes) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review