https://bugzilla.redhat.com/show_bug.cgi?id=2325807 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Nota - A |Review Request: |simple text editor for |maui-mauikit-nota - A |desktop and mobile |simple text editor for |computers. |desktop and mobile | |computers. --- Comment #7 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Comments: a) Thanks for name update b) The file src/android_files/gradle/wrapper/gradle-wrapper.jar is still in the source tarball. It is unclear where it comes from, raise an issue in the upstream repository or remove it. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code c) Packagers should not change licenses. Check with upstream if they want to update the licenses, and if so add a link to the corresponding accepted merge request in the spec file. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_fedora_licensing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325807 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325807%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue