https://bugzilla.redhat.com/show_bug.cgi?id=2315970 --- Comment #7 from Jos de Kloe <josdekloe@xxxxxxxxx> --- Thanks for your updated version! I am happy with your changes and have no further remarks, so now it is up to the assignee to actually approve the package if he agrees. As for the possible adding of tests, this is not required for approval I think. The packaging guidelines only says: "If the source code of the package provides a test suite, it should be executed in the %check section, whenever it is practical to do so." I have no personal experience with testing GUI based software, but I think it would be good if we could find some way to add tests in a later stage. (or have some tests included upstream). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2315970 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202315970%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
