Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pam_usb - Hardware authentication using ordinary USB Flash Drives https://bugzilla.redhat.com/show_bug.cgi?id=431320 ------- Additional Comments From guidolinfrancesco@xxxxxxxx 2008-02-02 14:55 EST ------- I patched the original Makefile because it install the documentation under $(DESTDIR)/usr/share/doc/pamusb instead of $(DESTDIR)/usr/share/doc/pam_usb-0.4.2. Also I remove the flag -Wall because it's just present in $RPM_OPT_FLAGS. Then I patched src/pad.c because with CFLAGS="$RPM_OPT_FLAGS" it give some warning: src/pad.c: In function 'pusb_pad_open_system': src/pad.c:97: warning: ignoring return value of 'chown', declared with attribute warn_unused_result src/pad.c: In function 'pusb_pad_update': src/pad.c:213: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result src/pad.c:215: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result src/pad.c: In function 'pusb_pad_compare': src/pad.c:240: warning: ignoring return value of 'fread', declared with attribute warn_unused_result src/pad.c:242: warning: ignoring return value of 'fread', declared with attribute warn_unused_result So I make some checks to the return value of chown, fwrite and fread, and if they fails I log and error with log_error(). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review