https://bugzilla.redhat.com/show_bug.cgi?id=2320142 --- Comment #16 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Petr Menšík from comment #14) > Just a minor issue remains, that %check is not present. At least > desktop-file-validate should be present in %check, not %install in my > opinion. > It should contain also appstream-util validate-relax > org.wfview.wfview.metainfo.xml for metainfo checking. > > It seems metainfo file validation is not optional: > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > #_app_data_validate_usage > Also basename of desktop file MUST match name of metainfo. This is not > currently the case. Since I have already given review+, I am not going to > revoke it again. Please fix AppData anyway. Thanks, fixed. I also fixed systemd service file mode, it shouldn't be executable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2320142 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202320142%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
