https://bugzilla.redhat.com/show_bug.cgi?id=2322082 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Unfortunately, there are still licensing/legal issues with the remaining test data files. Full details below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Since %pyproject_save_files is able to properly handle the license file, $ rpm -qL -p results/python3-scrape-schema-recipe-0.2.2-1.fc42.noarch.rpm /usr/lib/python3.13/site-packages/scrape_schema_recipe-0.2.2.dist-info/LICENSE it’s correct that you don’t manually include it, but you should change %pyproject_save_files scrape_schema_recipe -L to %pyproject_save_files scrape_schema_recipe -l so that the build will fail if the license file disappears in a future update. - You don’t need this: rm -r scrape_schema_recipe.egg-info It was never really necessary (although it became widespread because it was included in the output of pyp2rpm), but it is *especially* unnecessary with pyproject-rpm-macros since they always install a .dist-info directory, not egg-info, so it’s impossible for any bundled egg-info to be used by accident. - The %forgeurl, and therefore the URL, is incorrect; replace this %global forgeurl https://github.com/michacochran/scrape-schema-recipe with %global forgeurl https://github.com/micahcochran/scrape-schema-recipe - You’re right to remove test data with license issues before uploading to the lookaside cache, and the basic approach is sound, but there are still test data files with issues – unclear, proprietary or otherwise unacceptable licenses. For example, sweetestkitchen-truffles.html is CC-BY-NC-3.0, which is not-allowed in Fedora. I believe it’s necessary to remove the entire contents of scrape_schema_recipe/test_data/, except __init__.py. I also think it would make sense to patch scrape_schema_recipe/example_output.py to match the test data removals. You could change example_names = tuple(_ex_name_filename.keys()) to example_names = () or even just append that line to the end of that file. Notes: ====== Instead of patching out the tests you need to skip (which will be annoying to rebase if even a single byte of the tests in question changes), you could decorate them with unittest.skip – reducing the number of potentially-conflicting lines – or, even easier, you could use pytest as the runner and just skip the tests that way. BuildRequires: %{py3_dist pytest} […] # These tests require test data that we could not redistribute: k="${k-}${k+ and }not TestUnsetTimeDate" k="${k-}${k+ and }not TestTypeList" k="${k-}${k+ and }not (TestEscaping and test_unescape_ingredients)" %pytest -k "${k-}" Then you would be able to drop tests_without_proprietary_licensed_data.patch entirely. ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. The main license, Apache-2.0 is acceptable, but some or all test data is under unclear, proprietary, or not-allowed licenses. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0 and/or Creative Commons Attribution and/or Creative Commons Attribution-NonCommercial 3.0 and/or Creative Commons Attribution- NonCommercial-ShareAlike 2.5 and/or Creative Commons Attribution- ShareAlike 3.0", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0". 21 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2322082-python-scrape-schema- recipe/licensecheck.txt Test data is included in the binary RPMs, so if any is shipped, its licenses need to be included in the License field. Furthermore, some or all test data is under unclear, proprietary, or not-allowed licenses. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages This is a spurious diagnostic; the Python packages own these directories. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. Some or all test data is under unclear, proprietary, or not-allowed licenses. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines The most serious issue is that of test data licensing. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8485 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (Available tests pass.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: (%define is from expansion of rpmautospec macros) [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-scrape-schema-recipe-0.2.2-1.fc42.noarch.rpm python-scrape-schema-recipe-0.2.2-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuewsajhl')] checks: 32, packages: 2 python-scrape-schema-recipe.spec: W: invalid-url Source0: scrape-schema-recipe-0.2.2.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 11 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.1 s Requires -------- python3-scrape-schema-recipe (rpmlib, GLIBC filtered): python(abi) python3.13dist(extruct) python3.13dist(isodate) python3.13dist(requests) python3.13dist(setuptools) Provides -------- python3-scrape-schema-recipe: python-scrape-schema-recipe python3-scrape-schema-recipe python3.13-scrape-schema-recipe python3.13dist(scrape-schema-recipe) python3dist(scrape-schema-recipe) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -L rs-deps/ -b 2322082 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: SugarActivity, C/C++, PHP, Perl, Ocaml, fonts, Haskell, R, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Built with local dependencies: /home/ben/fedora/review/rs-deps/python3-extruct-0.17.0-1.fc42.noarch.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2322082 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202322082%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
