https://bugzilla.redhat.com/show_bug.cgi?id=2325070 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Benson Muite from comment #2) > - Package must not depend on deprecated() packages. > Note: python3-pytest7 is deprecated, you must not depend on it. Just noting that this is a false positive. > Comments: > a) license file is available at both > /usr/share/license/python3-pytest-freezer/LICENSE > /usr/lib/python3.13/site-packages/pytest_freezer-0.4.8.dist-info/LICENSE > though only the first has metadata. Thus neither > %pyproject_save_files pytest_freezer -l > nor > %pyproject_save_files pytest_freezer -L > is appropriate, but maybe worth updating this macro to have a flag for this > case at some point? Thanks for bringing this up. This is actually a perfect case for adding -L. Adding it isn’t required, but it’s a good idea. Passing -L asserts that %pyproject_save_files didn’t mark any license files. There is almost always still a license file in the .dist-info directory, but the build backend (flit-core in this case) didn’t support PEP 639 so it wasn’t installed with %license. If I add -L, then the build will start failing if the build backend is updated to support PEP 639 or the project switches to a different build backend that supports it, and that will be my cue to remove the manually- installed license file. > > b) Approved Again, thanks for the review! > c) Review of one of: > https://bugzilla.redhat.com/show_bug.cgi?id=2322084 > https://bugzilla.redhat.com/show_bug.cgi?id=2322082 > would be appreciated if time allows. Sure, they look straightforward enough. I’ll take both of them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325070 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325070%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
