https://bugzilla.redhat.com/show_bug.cgi?id=2275318 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2275317 --- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-gosimple-unidecode.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-gosimple-unidecode-1.0.1-1.fc41.src.rpm > This package blocks 2275317 as well since it is a dependency of it. done. > It seems that table.txt is not documentation but a file needed to rebuild table.go. It should not be marked as documentation IMHO, what do you think? The idea of this package is a library to be used by other libraries or binaries, so if new chars should be added it would be needed to be done upstream. Nobody should use these libraries shipped by Fedora to develop, so it's just a upstream thing. > I don't know if this is OK but one should try and contact upstream and let them know about this, if you ask me. What do you think? I'm afraid it's quite common in many Go projects to define the License at "root level" and not add copyright headers to code files. I'll try to contact upstream about it. > A hidden file has been included: /usr/share/gocode/src/github.com/gosimple/unidecode/.goipath Happens with all Go packages. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=2275317 [Bug 2275317] Review Request: golang-github-gosimple-slug - URL-friendly slugify with multiple languages support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2275318 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202275318%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
