https://bugzilla.redhat.com/show_bug.cgi?id=2323979 --- Comment #6 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Jaroslav Škarvada from comment #5) > Thanks Petr for the proxy review. > > @pmensik: > - please add build requires for the compiler, it seems gcc is used. > - if you plan to use this SPEC only on Fedora/RHEL you may to drop the SUSE > macros > - you may package the included examples, it may be useful for somebody There are some examples how to create own modules in the examples/modules, but I am not sure whether it makes sense to package it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2323979 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202323979%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue