https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #46 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you - package looks good to me now. I won't paste the full review template, but I think Yaakov and me went over everything more than once at this point. PACKAGE APPROVED. > What do you think of the > ``` > cd shell-rs > %cargo_generate_buildrequires -a -t > cd ~- > ``` > hack that I did? cd ~- is to shut up cd so that it doesn't end up echoing lines in the generated build requires :) You haven't run across a cleaner way to do it, by any chance? I don't think you even need to do "~-" - "cd .." would be enough. As far as I know, "cd" doesn't print to stdout at all and has no problems in %generate_buildrequires - maybe you're thinking of the problem caused by using pushd / popd? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c46 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
