https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #41 from Fabio Valentini <decathorpe@xxxxxxxxx> --- In general, the package looks good to me. Just some minor things that I'd like to have clarified and / or fixed: > https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval This is not really applicable - it's not a removal, this package is just not going to be built for i686 from the start. You wouldn't need to document or justify this ExcludeArch at all, but it doesn't hurt to include the link, I guess. > # Filter out soname provides for plugins > %global __provides_exclude_from ^%{_libdir}/papers/.*\\.so$ Please put this at the top of the spec file. Putting %globals in the middle of the spec file makes them really hard to find, and it might even get lost (i.e. become part of the %description, if it were just a few lines later). > -Dintrospection=disabled I seem to recall that some Rust-written tool is missing to get this enabled? Is this on your roadmap, or should we put that on the Rust SIG wishlist? > %{_libdir}/libppsshell-4.0.so.4{,.*} > %{_libdir}/libppsdocument-4.0.so.5{,.*} > %{_libdir}/libppsview-4.0.so.4{,.*} Is it intentional that some libraries are in the "main" papers package while the other two are in the "-libs" subpackage? > %{_datadir}/thumbnailers/ It looks like nothing owns this directory? I'm not sure whether I'm using DNF5 correctly, but its repoquery gives me zero results. If that is the case, this package will need to co-own the /usr/share/thumbnailers/ directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c41 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
