https://bugzilla.redhat.com/show_bug.cgi?id=2305882 --- Comment #31 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some quick first impressions: (In reply to Yaakov Selkowitz from comment #29) > There needs to be an extra grouping around ((MIT OR Apache-2.0) AND > Unicode-DFS-2016) since the entire statement is the license of a rust > dependency. This is not true. In SPDX expressions, "A AND (B AND C)" and "(A AND B) AND C" are equivalent, so you can drop parentheses around multiple clauses like that -> "A AND B AND C" (i.e. the SPDX "AND" operator is associative - and commutative, for that matter, so you can reorder freely, too). > There is nothing about rust packaging guidelines that covers > desktop/appstream validation. According to the guidelines, they can go in > either %check or %install; choosing the latter would avoid this issue > entirely. In this case, for simplicity, I would recommend to remove the %check bcond from the spec entirely, and use `%cargo_generate_buildrequires -a -t` explicitly. That avoids the whole issue on an even higher level. :) I'll do a full review later. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305882%23c31 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
