https://bugzilla.redhat.com/show_bug.cgi?id=2322762 --- Comment #26 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- > a) Sorry, fonts are for another package. > Please remove: > Requires: font(roboto) Sure, np :-) > b) One nit, please remove: > BuildRequires: python3-pytest-cov Right, done. > c) You could also modify > https://github.com/elParaguayo/qtile-extras/blob/main/tox.ini > so that only dependencies you need are included. This is a really good idea. I added a note about it to the specfile. Once I have to tweak the dependencies for a new upstream version or something, I will drop all the explicit deps and use this approach. > d) Approved Thank you very much for the review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2322762 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202322762%23c26 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
