https://bugzilla.redhat.com/show_bug.cgi?id=2292541 --- Comment #19 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- (In reply to Davide Cavalca from comment #18) > Given that Envision is used to compile stuff, shouldn't a bunch of these > also be Recommends (or possibly Requires, depending on whether Envision is > still usable if they're missing or not) ? Envision has a feature that manages this. I thought about adding things as Requires in subpackages, but Envision checks dependencies itself and offers commands for installing the dependencies cross-distro. What I have included as BRs is for building just Envision itself. > > %{_datarootdir}/applications/org.gabmus.envision.Devel.desktop > > %{_datarootdir}/icons/hicolor/scalable/apps/org.gabmus.envision.Devel.svg > > %{_datarootdir}/icons/hicolor/symbolic/apps/org.gabmus.envision.Devel-symbolic.svg > > %{_datarootdir}/metainfo/org.gabmus.envision.Devel.appdata.xml > > The "Devel" in there is suspicious, usually it's added when doing CI/test > builds, not for release builds. Can you double check that we aren't missing > some build flag or something to make it do a release build? Looks like I'm going to have to patch meson.build to fix this up. The switch to add Devel is based on running git commands. I'll work on something and send it upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2292541 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292541%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
