https://bugzilla.redhat.com/show_bug.cgi?id=2318053 --- Comment #10 from Peter Oliver <mavit@xxxxxxxxxxxx> --- (In reply to Cristian Le from comment #9) > To elaborate on the rust packaging, it is quite difficult to maintain a > package without running `rust2rpm` Does the resulting .spec vary much from one Tree-sitter parser to another? > and then if you want to add other > bindings like python and go, then the packaging becomes even more > complicated to satisfy each packaging guidelines simultaneously. Assuming we want the bindings for multiple languages, is it really harder to do this in a single spec file rather than artificially splitting it over multiple source packages? I think if we can get this right once, and make a suitable template, we can save a lot of effort in the long run. > For example > for rust packaging the whole repo source must be packaged for > re-distribution since it works like a header-only library, but then we would > have to filter out all of the bindings from the other languages. I don't think this is true. Calling %cargo_install on the source code fetched from GitHub does the right thing AFAICT. > But I have one recommendation. Instead of using the Makefile, > please use the CMake build system because that also generates the > <Pkg>Config.cmake files needed to be imported by other CMake/meson projects. Sounds good, but that appears to be a new feature of tree-sitter released only last month that we don't have in Fedora yet, and that not all parsers so-far support (ironically, tree-sitter-cmake included). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2318053 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318053%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue