https://bugzilla.redhat.com/show_bug.cgi?id=2292541 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |davide@xxxxxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #18 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Taking this review. > License: AGPL-3.0-only This doesn't look right. Because this is a binary package, you need to put the combined license here (the union of what is printed at the end of the build, and add what is printed at the end of the build as a comment before that). > BuildRequires: g++ Given that Envision is used to compile stuff, shouldn't a bunch of these also be Recommends (or possibly Requires, depending on whether Envision is still usable if they're missing or not) ? > %doc meson_options.txt This isn't a doc > %{_datarootdir}/envision nit: put a slash at the end to make it clear it's a directory > %{_datarootdir}/applications/org.gabmus.envision.Devel.desktop > %{_datarootdir}/icons/hicolor/scalable/apps/org.gabmus.envision.Devel.svg > %{_datarootdir}/icons/hicolor/symbolic/apps/org.gabmus.envision.Devel-symbolic.svg > %{_datarootdir}/metainfo/org.gabmus.envision.Devel.appdata.xml The "Devel" in there is suspicious, usually it's added when doing CI/test builds, not for release builds. Can you double check that we aren't missing some build flag or something to make it do a release build? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2292541 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292541%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
