[Bug 2323149] Review Request: nwg-dock-hyprland - A GTK3-based Dock for Hyprland

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2323149

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mikel@xxxxxxxxxxxxxxx
                 CC|                            |mikel@xxxxxxxxxxxxxxx
             Status|NEW                         |ASSIGNED



--- Comment #5 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
As with `nwg-drawer` or `nwg-dock` I would advise to use go2rpm to generate the
spec.

You can use the following command:

go2rpm -q --name nwg-dock-hyprland -f
https://github.com/nwg-piotr/nwg-dock-hyprland nwg-dock-hyprland

You can check
https://src.fedoraproject.org/rpms/nwg-drawer/blob/rawhide/f/nwg-drawer.spec
and https://src.fedoraproject.org/rpms/nwg-dock/blob/rawhide/f/nwg-dock.spec as
examples in case you need to modify the resulting spec.

About this module, I'm confused on why it's named `nwg-dock-hyprland` and not
like `github.com/nwg-piotr/nwg-drawer` or `github.com/nwg-piotr/nwg-dock`. Can
you suggest upstream to change the module name and adapt the go2rpm so it sets
the correct goipath? I'm referring to this:
https://github.com/nwg-piotr/nwg-dock-hyprland/blob/master/go.mod#L1

I would also recommend joining "Fedora Miracle" channel in Matrix to discuss
more about this if you want.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202323149%23c5

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux