https://bugzilla.redhat.com/show_bug.cgi?id=2314124 --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > 1. Where should I add the comment that you requested then, if not in the rust2rpm.toml? Not sure I understand what the problem is? You can do both to preserve those changes - That's what the "package.cargo-toml-patch-comments" setting is for. The values set there are added as comments associated with the patch generated by "rust2rpm -p". > 2. Regarding further updates: I tried re-running rust2rpm and rust2rpm -p, both removed the existing Patch line from the spec, so I’ll have to perform the same change again for every update. > Of course I can solve both cases with manual edits after spec re-generation, but I think you implied it’s possible to not do that manual work. It's possible to avoid *almost all* manual work when doing patches for Cargo.toml, but not *all*. Everything but re-applying Cargo.toml patch changes when running "rust2rpm -p" can be automated with rust2rpm.toml settings, and there's an RFE for automatically attempting to re-apply existing patches on re-runs too: https://pagure.io/fedora-rust/rust2rpm/issue/83 https://pagure.io/fedora-rust/rust2rpm/issue/278 I hope I'll be able to implement something like this for rust2rpm v27. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2314124 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314124%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
