https://bugzilla.redhat.com/show_bug.cgi?id=2318495 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- * The package doesn't have %check section. Any particular reason for that? * WTFPL must be listed along with MIT license in the "License" field. * The package bundles a substantial portion of pyaes library. You must add "Provides: bundled(pyaes)" * Some source files contains unnecessary shebangs (see rpmlint output below). These shebangs should be removed. Apart from this one I can't find any other issues so here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file must match the actual license (MIT and WTFPL). See my remark above. [x]: Package owns all directories that it creates. [!]: Package contains bundled pyaes library. See my remark above. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: No separate development files. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is not a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: No Python eggs. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged (0.0.10). [x]: Package does not include license text files separate from upstream. [-]: Sources weren't verified with gpgverify first in %prep. [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. Anyway it's noarch package. [?]: %check is present and all tests pass. See my remark above. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-unicrypto-0.0.10-1.fc42.noarch.rpm python-unicrypto-0.0.10-1.fc42.src.rpm ============================================================================= rpmlint session starts ============================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7ynz64u4')] checks: 32, packages: 2 python-unicrypto.src: E: spelling-error ('algos', 'Summary(en_US) algos -> altos') python-unicrypto.src: E: spelling-error ('algos', '%description -l en_US algos -> altos') python3-unicrypto.noarch: E: spelling-error ('algos', 'Summary(en_US) algos -> altos') python3-unicrypto.noarch: E: spelling-error ('algos', '%description -l en_US algos -> altos') python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pure/MD4.py 644 /usr/bin/env python3 python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/AES/AESGCM.py 644 /usr/bin/env python python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/RC4/RC4.py 644 /usr/bin/env python python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pycrypto/extra/AESGCM.py 644 /usr/bin/env python python3-unicrypto.noarch: W: no-documentation python3-unicrypto.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/unicrypto/backends/pycryptodomex/__init__.py /usr/lib/python3.13/site-packages/unicrypto/backends/cryptography/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/mbedtls/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/pure/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/pycrypto/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/pycryptodome/__init__.py python3-unicrypto.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/AES/gcc_bak_orig.py /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/AES/AESCCM.py ======================================== 2 packages and 0 specfiles checked; 8 errors, 3 warnings, 8 filtered, 8 badness; has taken 1.9 s ======================================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-unicrypto.noarch: E: spelling-error ('algos', 'Summary(en_US) algos -> altos') python3-unicrypto.noarch: E: spelling-error ('algos', '%description -l en_US algos -> altos') python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pure/MD4.py 644 /usr/bin/env python3 python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/AES/AESGCM.py 644 /usr/bin/env python python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/RC4/RC4.py 644 /usr/bin/env python python3-unicrypto.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/unicrypto/backends/pycrypto/extra/AESGCM.py 644 /usr/bin/env python python3-unicrypto.noarch: W: no-documentation python3-unicrypto.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/unicrypto/backends/pycryptodomex/__init__.py /usr/lib/python3.13/site-packages/unicrypto/backends/cryptography/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/mbedtls/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/pure/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/pycrypto/__init__.py:/usr/lib/python3.13/site-packages/unicrypto/backends/pycryptodome/__init__.py python3-unicrypto.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/AES/gcc_bak_orig.py /usr/lib/python3.13/site-packages/unicrypto/backends/pure/external/AES/AESCCM.py 1 packages and 0 specfiles checked; 6 errors, 3 warnings, 4 filtered, 6 badness; has taken 0.6 s Source checksums ---------------- https://github.com/skelsec/unicrypto/archive/0.0.10/unicrypto-0.0.10.tar.gz : CHECKSUM(SHA256) this package : 3daefcdf8e71f9300032393ad85d7f22fc08d07dc05cf7776019b9480bd8506a CHECKSUM(SHA256) upstream package : 3daefcdf8e71f9300032393ad85d7f22fc08d07dc05cf7776019b9480bd8506a Requires -------- python3-unicrypto (rpmlib, GLIBC filtered): python(abi) python3.13dist(pycryptodomex) Provides -------- python3-unicrypto: python-unicrypto python3-unicrypto python3.13-unicrypto python3.13dist(unicrypto) python3dist(unicrypto) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2318495 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: PHP, fonts, Haskell, Ocaml, Perl, SugarActivity, C/C++, R, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2318495 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318495%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
