https://bugzilla.redhat.com/show_bug.cgi?id=2314746 --- Comment #16 from Alexey Lunev <cheembox573@xxxxxxxxx> --- > > install -m 0755 -vp gdu.1 %{buildroot}%{_mandir}/man1/ > > Should be 0644 Fixed. (compressed man page was 0644 anyway) > > export GOPATH=$(pwd)/_build:%{gopath} > > Is this required? Remains of individual `%gotest`s, removed. > > %doc README.md gdu.1.md > > > > %{_bindir}/gdu > > Pure cosmetic thing, but can you remove the empty line between %doc and > %{_bindir}? Sure, removed. > > %global godocs docs INSTALL.md README.md gdu.1.md > > (...) > > %doc README.md gdu.1.md > > - Does it make sense to install gdu.1.md when the manpage is created from it? Forgot about it, removed `gdu.1.md` from installing. > - Does it make sense to ship INSTALL.md? No, removed from installing. > - Why not add docs to %doc? `docs` only has one file, `run-books.md`, and it is hints for release process (useful only for developers). I currently removed `docs` from installing anywhere in spec file, tell me if this folder should be packaged. New spec URL: https://download.copr.fedorainfracloud.org/results/xbt573/gdu/srpm-builds/08180427/gdu.spec New SRPM URL: https://download.copr.fedorainfracloud.org/results/xbt573/gdu/srpm-builds/08180427/gdu-5.29.0-1.src.rpm Link to successful copr build: https://copr.fedorainfracloud.org/coprs/xbt573/gdu/build/8180427/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2314746 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314746%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
