Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gridengine - Grid Engine - Distributed Computing Management software https://bugzilla.redhat.com/show_bug.cgi?id=316141 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-01 10:42 EST ------- Created an attachment (id=293735) --> (https://bugzilla.redhat.com/attachment.cgi?id=293735&action=view) rpmlint log for 6.1u3-1 binary rpms Well, actually I was checking 6.1u3-1, so anyway I write comments on 6.1u3-1 for now. Will you merge the fix for -1 to -2 and upload new -3 srpm later? First comment on 6.1u3-1: scrartch build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=380936 A. rpmlint for src.rpm * Source file permission --------------------------------------------------------------- gridengine.src: W: strange-permission arch 0755 gridengine.src: W: strange-permission sgemaster 0755 gridengine.src: W: strange-permission sge.csh 0755 gridengine.src: W: strange-permission sge.sh 0755 gridengine.src: W: strange-permission sgeexecd 0755 --------------------------------------------------------------- - All source files must have 0644 permission. Change the permission when installing them if needed. B. For spec file: B-2: %prep * Source file override --------------------------------------------------------------- cp source/dist/util/arch %SOURCE8 --------------------------------------------------------------- - Source file must not be overwritten. If you want to "define" sgearch, you can do like --------------------------------------------------------------- %install sgearch=`sh source/dist/util/arch` --------------------------------------------------------------- B-3: %build * java_home --------------------------------------------------------------- export JAVA_HOME=/usr/lib/jvm/java --------------------------------------------------------------- - Please consider to use %java_home macro (defined by %_sysconfdir/rpm/macros.jpackage in jpackage-utils, required by java-1.5.0-gcj-devel) B-4: %install * Timestamps - When using "cp" or "install" commands, please add "-p" option to keep timestamps on installed files. B-5: %files * Macros - %_sysconfdir/rc.d/init.d must be replaced with %_initrddir. C. rpmlint Only checked for binary rpms (not checked for actually installed rpms), but many rpmlint complaints... (attached) SUMMARY: * E: arch-dependent-file-in-usr-share - arch dependent file must not be under %_datadir. A possible resolution is to move arch dependent files to under %_libexecdir and make a symlink against them. * E: binary-or-shlib-defines-rpath - Remove strange rpath from binaries * W: devel-file-in-non-devel-package - Would you explain why these files are in gridengine, not in gridengine-devel package? * E: executable-marked-as-config-file - Executables must be not marked as %config file (even if they are under %_sysconfdir) * E: missing-mandatory-lsb-keyword * W: no-reload-entry * E: no-status-entry - Rewrite initrd script to make it more LSB compliant. * E: non-executable-script - Scripts without executable permission should not have shebangs. * E: script-without-shebang - Script with executable permission should have shebangs. * W: spurious-executable-perm - source files in debuginfo rpm must have 0644 permission You should fix this by changing permission of files under $RPM_BUILD_DIR. W: summary-not-capitalized - Summary must begin with captal letters. W: symlink-should-be-relative - Change symlinks from absolute to relative for chroot issues and so on. D. build.log * Fedora specific compilation flags - On some parts, fedora specific compilation flags are not honored correctly. On i386: ---------------------------------------------------------------------------- 14777 _________3_r_d_p_a_r_t_y__Q_M_A_K_E_______ 14778 make all-recursive 14779 make[1]: Entering directory `/builddir/build/BUILD/gridengine/source/3rdparty/qmake/LINUX86_26' 14780 Making all in glob 14781 make[2]: Entering directory `/builddir/build/BUILD/gridengine/source/3rdparty/qmake/LINUX86_26/glob' 14782 gcc -DHAVE_CONFIG_H -I. -I../../glob -I.. -g -O2 -c ../../glob/glob.c 14783 gcc -DHAVE_CONFIG_H -I. -I../../glob -I.. -g -O2 -c ../../glob/fnmatch.c 14784 rm -f libglob.a 14785 ar cru libglob.a glob.o fnmatch.o 14786 ranlib libglob.a 14787 make[2]: Leaving directory `/builddir/build/BUILD/gridengine/source/3rdparty/qmake/LINUX86_26/glob' 14788 make[2]: Entering directory `/builddir/build/BUILD/gridengine/source/3rdparty/qmake/LINUX86_26' 14789 gcc -DHAVE_CONFIG_H -I. -I.. -I. -DLIBDIR=\"/usr/local/lib\" -DINCLUDEDIR=\"/usr/local/include\" -g -O2 -Wall -Wno-error -DLINUX -c ../main.c 14790 gcc -DHAVE_CONFIG_H -I. -I.. -I. -DLIBDIR=\"/usr/local/lib\" -DINCLUDEDIR=\"/usr/local/include\" -g -O2 -Wall -Wno-error -DLINUX -c ../commands.c ........... ------------------------------------------------------------------------------ F. etc * Clean up binaries under %_bindir - Would you clean up unneeded binaries under %_bindir (if any)? * Especially, qt-devel has %_libdir/qt-3.3/bin/qmake in $PATH and "which qmake" always returns qt-devel qmake. IMO %_bindir/qmake should be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review