https://bugzilla.redhat.com/show_bug.cgi?id=2321778 --- Comment #7 from Robin Jarry <rjarry@xxxxxxxxxx> --- (In reply to Benson Muite from comment #5) > Initial comments: > a) First part of soname should be in > %{_libdir}/%{name}.so.* > so use > %{_libdir}/%{name}.so.0.2* Actually, SONAME is .0 only: $ objdump -p build/libecoli.so.0.2.0 | grep SONAME SONAME libecoli.so.0 Is it OK if I change to: %{_libdir}/%{name}.so.0* > b) Doc package should also have the license file as it does not depend on > the main package > c) Devel package should have > Requires: %{name}%{?_isa} = %{version}-%{release} > to ensure it has main library and the license file when installed > d) Should LicenseRef-Fedora-Public-Domain also be added: > BSD 3-Clause License and/or Public domain > ----------------------------------------- > libecoli-0.2.0-build/libecoli-0.2.0/include/ecoli_murmurhash.h b, c and d, done. Spec URL: https://raw.githubusercontent.com/rjarry/libecoli/8fb9678a9556f432fce2a559fb283cbdc50634a0/libecoli.spec SRPM URL: https://f.jarry.cc/libecoli-0.2.0-3.fc40.src.rpm I do have a question regarding man page links. Doxygen automatically generates man "links" that are plain text files which contain a reference to another man page. Is it possible to automatically replace these with a symbolic link after compression? rpmlint complains about duplicate files: libecoli-devel.x86_64: W: files-duplicate /usr/share/man/man3/ec_parse_t.3.gz /usr/share/man/man3/EC_INIT_REGISTER.3.gz:/usr/share/man/man3/EC_NODE_CMD.3.gz:/usr/share/man/man3/EC_NODE_OR.3.gz:/usr/share/man/man3/EC_NODE_SEQ.3.gz:/usr/share/man/man3/EC_NODE_SUBSET.3.gz:(and 39 more) libecoli-devel.x86_64: W: files-duplicate /usr/share/man/man3/ec_vlog.3.gz /usr/share/man/man3/EC_LOG.3.gz:/usr/share/man/man3/EC_LOG_TYPE_REGISTER.3.gz:/usr/share/man/man3/EC_VLOG.3.gz:/usr/share/man/man3/ec_log.3.gz:/usr/share/man/man3/ec_log_default_cb.3.gz:(and 7 more) libecoli-devel.x86_64: W: files-duplicate /usr/share/man/man3/ec_pnode_unlink_child.3.gz /usr/share/man/man3/EC_PARSE_NOMATCH.3.gz:/usr/share/man/man3/EC_PNODE_FOREACH_CHILD.3.gz:/usr/share/man/man3/EC_PNODE_GET_ROOT.3.gz:/usr/share/man/man3/EC_PNODE_ITER_NEXT.3.gz:/usr/share/man/man3/ec_parse.3.gz:(and 21 more) libecoli-devel.x86_64: W: files-duplicate /usr/share/man/man3/ec_strvec_val.3.gz ... Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2321778 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202321778%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
