https://bugzilla.redhat.com/show_bug.cgi?id=2321778 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |benson_muite@xxxxxxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #5 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Initial comments: a) First part of soname should be in %{_libdir}/%{name}.so.* so use %{_libdir}/%{name}.so.0.2* b) Doc package should also have the license file as it does not depend on the main package c) Devel package should have Requires: %{name}%{?_isa} = %{version}-%{release} to ensure it has main library and the license file when installed d) Should LicenseRef-Fedora-Public-Domain also be added: BSD 3-Clause License and/or Public domain ----------------------------------------- libecoli-0.2.0-build/libecoli-0.2.0/include/ecoli_murmurhash.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2321778 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202321778%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
