https://bugzilla.redhat.com/show_bug.cgi?id=2318062 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxx --- Comment #1 from Cristian Le <fedora@xxxxxxxxx> --- The link is 404ed, but I am giving some preliminary comments based on your current GH repo status. A few things to change: - Don't change the description inside of `Cargo.toml` - The rpm description should be fine as it was - The summary seems grammatically incomplete. Maybe add a `into ratatui` or `for ratatui` - `criterion` is something you will have to constantly patch. Try using something like: ``` [requires] build = [ "tomcli", ] [scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ] ``` - There are a few unnecessary files being included in the `devel` package which would be nice to have removed: `flake.*` You can just add an additional `rm` line in the `scripts.prep.post` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2318062 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318062%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
