https://bugzilla.redhat.com/show_bug.cgi?id=2276417 --- Comment #10 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: a86ad903a6c3526a23708517d26e597f4a86b3fae14406ff73b1411fa77453f7469c02e8b378fc7196d31f6ce7333c065e4e2c1f2dc2b2034dcf3d7cc8868cb6) is original. Ok. Summary verified in script/perlimports. Ok. Description verified in script/perlimports. Ok. No XS code, noarch BuildArch is Ok. License verified in LICENSE, Makefile.PL, script/dump-perl-exports, script/perlimports, README.md, lib/App/perlimports/CLI, lib/App/perlimports/ExportInspector.pm, lib/App/perlimports/Sandbox.pm, lib/App/perlimports/Document.pm, lib/App/perlimports/Annotations.pm, lib/App/perlimports/Include.pm, lib/App/perlimports/Role/Logger.pm, lib/App/perlimports/Config.pm, and lib/App/perlimports.pm. Ok. FIX: Remove '>= 5.18' from perl-interpreter. That package has an epoch and would match any version. Use 'perl(:VERSION) >= 5.18' instead. TODO: Do not use %{__perl} macro. Underscored macros are an private macros for rpm-build. Instead, call 'perl' program directly. FIX: Build-require 'perl(feature)' (script/dump-perl-exports:5). FIX: Build-require 'perl(FindBin)' (t/find-bin.t:14). FIX: Build-require 'perl(strict)' (Makefile.PL:2). FIX: BUild-require 'perl(utf8)' (lib/App/perlimports/CLI.pm:4). FIX: Build-require 'perl(warnings)' (Makefile.PL:3). FIX: Build-require 'perl(lib)' (t/Sandbox.t:4). TODO: Build-require 'perl(DateTime)' (t/datetime.t:10). TODO: Build-require 'perl(File::chdir)' (t/typeglob.t:8). TODO: Build-require 'perl(File::Spec::Functions) >= 3.75' (t/func-in-use.t:13). TODO: Build-require 'perl(Geo::IP)' (t/geo-ip.t:12). TODO: Build-require 'perl(Getopt::Long) >= 2.40' (t/never-exports.t:10). TODO: Build-require 'perl(HTML::TableExtract)' (t/symbol-as-method-call.t:9). TODO: Build-require 'perl(HTTP::Status) >= 6.28' (t/export-tags.t:9). TODO: Build-require 'perl(HTTP::Tiny)' (t/fully-qualified.t:9). TODO: Build-require 'perl(Import::Into)' (t/ExportInspector/load.t:11). TODO: Build-require 'perl(IP::Random) >= 1.200230' (t/regex-replacement.t:8). TODO: Build-require 'perl(Lingua::EN::Inflect)' (t/cast-in-regex.t:9). TODO: Build-require 'perl(List::AllUtils)' (t/after.t:10). TODO: Build-require 'perl(LWP::UserAgent) >= 5' (t/never-exports.t:10). TODO: Build-require 'perl(MetaCPAN::Moose)' (t/ExportInspector/SubExporter.t:11). TODO: Build-require 'perl(Mojo::URL)' (t/warning.t:8). TODO: Build-require 'perl(Mojo::Util)' (t/cast.t:8). TODO: Build-require 'perl(Mojolicious) >= 8.25' (t/func-in-use.t:25). TODO: Build-require 'perl(Moose)' (t/moose.t:10). TODO: Build-require 'perl(MooseX::Types)' (t/moosex-types-moose.t:10). TODO: Build-require 'perl(MooseX::Types::Moose)' (t/ExportInspector/SubExporter.t:11). TODO: Build-require 'perl(MooseX::Types::Path::Class)' (t/moose-types.t:10). TODO: Build-require 'perl(MooseX::Types::UUID)' (t/memoize.t:23). TODO: Build-require 'perl(Object::Tap)' (t/symbol-as-method-call.t:9). TODO: Build-require 'perl(Path::Class)' (t/ExportInspector/SubExporter.t:11). TODO: Build-require 'perl(Perl::Critic::Utils)' (t/cli-args.t:12). TODO: Build-require 'perl(Pithub)' (t/cpan-modules/pithub.t:10). TODO: Build-require 'perl(Test2::V0) (t/meta.t:8). TODO: Build-require 'perl(Test::HTML::Lint)' (t/test-builder.t:7). TODO: Build-require 'perl(Test::Most)' (t/test-most.t:9). TODO: Build-require 'perl(UUID)' (t/memoize.t:23). FIX: Do not list '%{perl_vendorlib}/App/perlimports/Role/Logger.pm' in %files section. It's already included with '%{perl_vendorlib}/App/perlimports/Role' line. All mandatory tests pass. Ok. TODO: You can run the test in parallel, if you put this line betwneen %check and make test lines: export HARNESS_OPTIONS=j$(perl -e 'if ($ARGV[0] =~ /.*-j([0-9][0-9]*).*/) {print $1} else {print 1}' -- '%{?_smp_mflags}') $ rpmlint perl-App-perlimports.spec ../SRPMS/perl-App-perlimports-0.000054-1.fc42.src.rpm ../RPMS/noarch/perl-App-perlimports-0.000054-1.fc42.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-App-perlimports.noarch: E: spelling-error ('goimports', '%description -l en_US goimports -> go imports, go-imports, imports') perl-App-perlimports.noarch: E: spelling-error ('perltidy', '%description -l en_US perltidy -> perfidy') perl-App-perlimports.noarch: E: spelling-error ('perlcritic', '%description -l en_US perlcritic -> hypercritical') perl-App-perlimports.src: E: spelling-error ('goimports', '%description -l en_US goimports -> go imports, go-imports, imports') perl-App-perlimports.src: E: spelling-error ('perltidy', '%description -l en_US perltidy -> perfidy') perl-App-perlimports.src: E: spelling-error ('perlcritic', '%description -l en_US perlcritic -> hypercritical') === 2 packages and 1 specfiles checked; 6 errors, 0 warnings, 6 filtered, 6 badness; has taken 0.9 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-App-perlimports-0.000054-1.fc42.noarch.rpm -rwxr-xr-x 1 root root 5465 Oct 23 02:00 /usr/bin/dump-perl-exports -rwxr-xr-x 1 root root 24270 Oct 23 02:00 /usr/bin/perlimports drwxr-xr-x 2 root root 0 Oct 23 02:00 /usr/share/doc/perl-App-perlimports -rw-r--r-- 1 root root 430 Jun 29 21:33 /usr/share/doc/perl-App-perlimports/CONTRIBUTORS -rw-r--r-- 1 root root 8691 Jun 29 21:33 /usr/share/doc/perl-App-perlimports/Changes -rw-r--r-- 1 root root 662 Jun 29 21:33 /usr/share/doc/perl-App-perlimports/README.md drwxr-xr-x 2 root root 0 Oct 23 02:00 /usr/share/licenses/perl-App-perlimports -rw-r--r-- 1 root root 19732 Jun 29 21:33 /usr/share/licenses/perl-App-perlimports/LICENSE -rw-r--r-- 1 root root 1256 Oct 23 02:00 /usr/share/man/man1/dump-perl-exports.1.gz -rw-r--r-- 1 root root 9523 Oct 23 02:00 /usr/share/man/man1/perlimports.1.gz -rw-r--r-- 1 root root 1201 Oct 23 02:00 /usr/share/man/man3/App::perlimports.3pm.gz -rw-r--r-- 1 root root 1270 Oct 23 02:00 /usr/share/man/man3/App::perlimports::Annotations.3pm.gz -rw-r--r-- 1 root root 1193 Oct 23 02:00 /usr/share/man/man3/App::perlimports::CLI.3pm.gz -rw-r--r-- 1 root root 1240 Oct 23 02:00 /usr/share/man/man3/App::perlimports::Config.3pm.gz -rw-r--r-- 1 root root 1334 Oct 23 02:00 /usr/share/man/man3/App::perlimports::Document.3pm.gz -rw-r--r-- 1 root root 1955 Oct 23 02:00 /usr/share/man/man3/App::perlimports::ExportInspector.3pm.gz -rw-r--r-- 1 root root 1192 Oct 23 02:00 /usr/share/man/man3/App::perlimports::Include.3pm.gz -rw-r--r-- 1 root root 1098 Oct 23 02:00 /usr/share/man/man3/App::perlimports::Role::Logger.3pm.gz -rw-r--r-- 1 root root 1321 Oct 23 02:00 /usr/share/man/man3/App::perlimports::Sandbox.3pm.gz drwxr-xr-x 2 root root 0 Oct 23 02:00 /usr/share/perl5/vendor_perl/App drwxr-xr-x 2 root root 0 Oct 23 02:00 /usr/share/perl5/vendor_perl/App/perlimports -rw-r--r-- 1 root root 781 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports.pm -rw-r--r-- 1 root root 3005 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/Annotations.pm -rw-r--r-- 1 root root 15812 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/CLI.pm -rw-r--r-- 1 root root 5612 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/Config.pm -rw-r--r-- 1 root root 34176 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/Document.pm -rw-r--r-- 1 root root 15688 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/ExportInspector.pm -rw-r--r-- 1 root root 24366 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/Include.pm drwxr-xr-x 2 root root 0 Oct 23 02:00 /usr/share/perl5/vendor_perl/App/perlimports/Role -rw-r--r-- 1 root root 794 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/Role/Logger.pm -rw-r--r-- 1 root root 1791 Jun 29 21:33 /usr/share/perl5/vendor_perl/App/perlimports/Sandbox.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-App-perlimports-0.000054-1.fc42.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl(App::perlimports) 1 perl(App::perlimports::Annotations) 1 perl(App::perlimports::CLI) 1 perl(App::perlimports::Config) 1 perl(App::perlimports::Document) 1 perl(App::perlimports::ExportInspector) 1 perl(App::perlimports::Include) 1 perl(App::perlimports::Sandbox) 1 perl(Capture::Tiny) 1 perl(Class::Inspector) 1 perl(Data::Dumper) 1 perl(Data::UUID) 1 perl(feature) 1 perl(File::Basename) 1 perl(File::XDG) 1 perl(Getopt::Long::Descriptive) 1 perl(List::Util) 1 perl(Log::Dispatch) 1 perl(Memoize) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moo::Role) 1 perl(MooX::StrictConstructor) 1 perl(Path::Iterator::Rule) 1 perl(Path::Tiny) 1 perl(Pod::Usage) 1 perl(PPI::Document) 1 perl(PPIx::Utils::Classification) 1 perl(Ref::Util) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::HandlesVia) 1 perl(Symbol::Get) 1 perl(Text::Diff) 1 perl(Text::SimpleTable::AutoWidth) 1 perl(TOML::Tiny) 1 perl(Try::Tiny) 1 perl(Types::Standard) 1 perl(utf8) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Require: 'perl(Perl::Tidy) >= 20220613' (dist.ini:35, lib/App/perlimports/Include.pm:564). $ rpm -q --provides -p ../RPMS/noarch/perl-App-perlimports-0.000054-1.fc42.noarch.rpm | sort -f | uniq -c 1 perl(App::perlimports) = 0.000054 1 perl(App::perlimports::Annotations) = 0.000054 1 perl(App::perlimports::CLI) = 0.000054 1 perl(App::perlimports::Config) = 0.000054 1 perl(App::perlimports::Document) = 0.000054 1 perl(App::perlimports::ExportInspector) = 0.000054 1 perl(App::perlimports::Include) = 0.000054 1 perl(App::perlimports::Role::Logger) = 0.000054 1 perl(App::perlimports::Sandbox) = 0.000054 1 perl-App-perlimports = 0.000054-1.fc42 Binary provides are Ok. $ resolvedeps f42-build ../RPMS/noarch/perl-App-perlimports-0.000054-1.fc42.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 42 (https://koji.fedoraproject.org/koji/taskinfo?taskID=125120922). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct all FIX items, consider correcting TODO items, and provide an updated spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2276417 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276417%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
