https://bugzilla.redhat.com/show_bug.cgi?id=2318051 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxx --- Comment #13 from Cristian Le <fedora@xxxxxxxxx> --- Only 1 issue, please change the reference of the Source2 from `master` to the closest tag (seems to be `v0.24.3` right now). Reasoning is that upstream frequently updates the copyright section and the files can quickly be mismatched. Alternatively you can copy the license locally instead of pointing it to an url. Other than that lgtm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2318051 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318051%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
