https://bugzilla.redhat.com/show_bug.cgi?id=2309375 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Don't do this: > loosen dep bounds > sed -i \ > -e '/google-cloud-storage.*]$/{n;s/^version.*$/version = ">=0.15.0"/;}' \ > -e '/rstest]$/{n;s/^version.*$/version = ">=0.17.0"/;}' \ > -e '/rusqlite.*$/{n;s/^version.*$/version = ">=0.29.0"/;}' \ > -e '/^features.*"bundled"]$/d' \ > Cargo.toml The only supported way of modifying Cargo.toml contents is with "rust2rpm -p": The contents of Cargo.toml affect the generated spec file, and so they need to happen *before* the spec file is written. If you make changes to Cargo.toml *after* the spec file is generated, they might be out of sync and produce broken packages. Additionally, open-ended version requirements like ">=0.15.0" might be commonplace in other package ecosystems like Python, but they're really bad in the Rust ecosystem because they throw off the tooling and will just crate problems eventually. If you need to loosen dependency bounds, do something like ">=0.15,<0.23" instead (in this example, if you know that the project is compatible with all release branches between 0.15.x and 0.22.x). Additionally, this one doesn't fit with the rest and isn't documented right now: > -e '/^features.*"bundled"]$/d' This should probably be documented with something like "don't build vendored sqlite3 and statically link it" (or whatever library this is actually for - see, sed is bad for seeing what actually happens to the file ;)) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2309375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309375%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
