https://bugzilla.redhat.com/show_bug.cgi?id=2309448 --- Comment #7 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Michal Ambroz from comment #2) > Issues found: > - License - there is standalone LICENSE file which is not used in the > %license, please fix No it's there thanks to "%pyproject_save_files -l" macro. Check it with rpm -qpL ``` Nostromo ~/rpmbuild/SPECS: rpm -qpL ../RPMS/noarch/python3-solc-ast-1.2.10-1.fc40.noarch.rpm /usr/lib/python3.12/site-packages/py_solc_ast-1.2.10.dist-info/LICENSE Nostromo ~/rpmbuild/SPECS: ``` > - Naming - on the beginning of the spec file you refer to pypi_name solcast, > but then using > pypi_source of py-solc-ast ... please make it aligned I changed it to match PyPi naming and to avoid confusion. > The "solcast" (weather forecasting) is not in fedora, but apparently > there is some potential name clash > already in pypi and it might be usefull to bring this issue even to > upstream. Will do. > - shebangs - python files being installed to sitelib should be stripped from > having shebangs as they are not meant to be directly executable (see rpmlint) Done. Spec URL: https://peter.fedorapeople.org/packages/python-solc-ast.spec SRPM URL: https://peter.fedorapeople.org/packages/python-solc-ast-1.2.10-1.fc40.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=125083103 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2309448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309448%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
