[Bug 2291289] Review Request: ocaml-linenoise - Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2291289



--- Comment #14 from U2FsdGVkX1@xxxxxxxxx ---
(In reply to Jerry James from comment #13)
> Sorry for the silence.  Unfortunately, I still see these lines in the
> rpmlint output:
> 
> ocaml-linenoise.x86_64: W: undefined-non-weak-symbol
> /usr/lib64/ocaml/linenoise/linenoise.cmxs linenoiseWasInterrupted
> (/usr/lib64/ocaml/linenoise/linenoise.cmxs)
> ocaml-linenoise.x86_64: W: undefined-non-weak-symbol
> /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so linenoiseWasInterrupted
> (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so)
> 
> and indeed:
> 
> $ readelf -Wa /usr/lib64/liblinenoise.so.0.0.0 | grep -F Interrupted
> $
> 
> This is due to linenoise-symbol-visibility.patch.  I think you will need to
> add LINENOISE_EXPORTED to the linenoiseWasInterrupted declaration for it to
> be exported.

https://src.fedoraproject.org/rpms/linenoise/pull-request/3
I have submitted a new Pull Request to fix this problem.
Sorry, I am a new packager and did not find this stupid error.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2291289

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291289%23c14

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux