https://bugzilla.redhat.com/show_bug.cgi?id=2314746 --- Comment #15 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > install -m 0755 -vp gdu.1 %{buildroot}%{_mandir}/man1/ Should be 0644 > export GOPATH=$(pwd)/_build:%{gopath} Is this required? > %doc README.md gdu.1.md > > %{_bindir}/gdu Pure cosmetic thing, but can you remove the empty line between %doc and %{_bindir}? > %global godocs docs INSTALL.md README.md gdu.1.md > (...) > %doc README.md gdu.1.md - Does it make sense to install gdu.1.md when the manpage is created from it? - Does it make sense to ship INSTALL.md? - Why not add docs to %doc? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2314746 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314746%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
