https://bugzilla.redhat.com/show_bug.cgi?id=2283126 Daniel Milnes <daniel@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |daniel@xxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |daniel@xxxxxxxxxxxxxxxx --- Comment #2 from Daniel Milnes <daniel@xxxxxxxxxxxxxxxx> --- Package does not currently build in Mock (https://download.copr.fedorainfracloud.org/results/thebeanogamer/python-ansible-pylibssh/fedora-rawhide-x86_64/08160092-python-ansible-pylibssh-epel/builder-live.log.gz). I think this is because setuptools_scm 7 merged setuptools-scm-git-archive into the main package. I think you can drop Patch0 as upstream have made the equivalent change (https://github.com/ansible/pylibssh/pull/501/files). If we're going to carry modifications to coverage in Patch1, could we merge the "sed -i -e '/cov/d' pytest.ini" into that patchset? Might be worth adding a comment explaining why you're "export PYTHONPATH=bin"-ing. Otherwise looks good, I'll happily do a full review once it builds. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2283126 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283126%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
