https://bugzilla.redhat.com/show_bug.cgi?id=2284256 --- Comment #4 from Daniel Milnes <daniel@xxxxxxxxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-ansible-windows/fedora-rawhide-x86_64/08159944-ansible-collection-ansible-windows/ansible-collection-ansible-windows.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-ansible-windows/fedora-rawhide-x86_64/08159944-ansible-collection-ansible-windows/ansible-collection-ansible-windows-2.5.0-1.fc42.src.rpm Thanks for having a look at this! > Latest version isn't packaged Fixed https://github.com/thebeanogamer/ansible-collection-ansible-windows/commit/53106b88ad23cdd31a57ca7c7a1bc7990730b4be > it might be nice actually to go through some earlier version for EPEL Yep, I'm happy to publish EPEL branches with the old releases. > BuildRequires: python3dist(mock) is not needed - it uses unittest.mock instead. Fixed https://github.com/thebeanogamer/ansible-collection-ansible-windows/commit/992c98bbb39bed5fb08550f8771a397c6a1da1c6 > It fails to build for epel8 because it does not support the new %bcond syntax: Fixed https://github.com/thebeanogamer/ansible-collection-ansible-windows/commit/e241f76bea87b8c0d68bfabb0c22f7e98fa880c9 > Please add a note to the patch that this is downstream only Fixed https://github.com/thebeanogamer/ansible-collection-ansible-windows/commit/966446e681aedf60ac406347241e0957dd9b7027, might be worth adding to the template on https://docs.fedoraproject.org/en-US/packaging-guidelines/Ansible_collections/#_example_specfile Please let me know if there's anything else to fix, or you have any pending reviews you'd like me to look at. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2284256 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202284256%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
