https://bugzilla.redhat.com/show_bug.cgi?id=2284297 Orion Poplawski <orion@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxx CC| |orion@xxxxxxxx Flags| |fedora-review? --- Comment #2 from Orion Poplawski <orion@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file idrac_license.yml is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text This is a false positive - this file is a module and play - There are some files with a BSD license: plugins/module_utils/dellemc_idrac.py: BSD 2-Clause License plugins/module_utils/idrac_redfish.py: BSD 2-Clause License plugins/module_utils/ome.py: BSD 2-Clause License plugins/module_utils/redfish.py: BSD 2-Clause License plugins/module_utils/session_utils.py: BSD 2-Clause License plugins/module_utils/utils.py: BSD 2-Clause License This should be noted and added to the license tag. Might be worth bringing up with upstream as well. - Note that the patch is a downstream only patch - Should update to the latest - We should get upstream to switch to unittest.mock ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later and/or GNU General Public License, Version 2", "BSD 2-Clause License". 926 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/ansible-collection-dellemc- openmanage/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/ansible/collections, /usr/share/ansible, /usr, /usr/share/doc, /usr/share/licenses, /usr/share, /usr/share/ansible/collections/ansible_collections [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ansible/collections/ansible_collections, /usr/share, /usr/share/ansible/collections, /usr/share/licenses, /usr/share/doc, /usr/share/ansible, /usr [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 942101 bytes in 110 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: Source 3 is not passed to gpgverify. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: ansible-collection-dellemc-openmanage-9.3.0-1.fc41.noarch.rpm ansible-collection-dellemc-openmanage-9.3.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpffaosb76')] checks: 32, packages: 2 ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/negative_scenarios_with_maintenance_window/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/default/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/default/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/system_attr/cleanup.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/idrac_attr/cleanup.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/lifecycle_controller_attr/cleanup.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_storage_volume/molecule/apply_time_onreset_reboot_server_true_force_reboot_true/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/idrac_attr/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/lifecycle_controller_attr/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/system_attr/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/clear_pending_attributes/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_boot/molecule/boot_options_using_boot_option_reference_enabled_true/molecule.yml:(and 12 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_storage_volume/tests/inventory /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_boot/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_export_server_config_profile/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_firmware/tests/inventory:(and 8 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_boot/molecule/boot_source_override_enabled_as_continuous_reset_type_none/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/reset_bios/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/reset_bios_with_reset_type_as_force_restart/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_immediate_with_jobwait/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_immediate/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_with_maintenance_window/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_on_reset/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_on_reset_with_maintenance_window/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_job_queue/molecule/delete_job/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_firmware/molecule/default/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_firmware/molecule/negative_scenarios/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_gather_facts/molecule/backplane/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_gather_facts/molecule/bios/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_gather_facts/molecule/controller/molecule.yml:(and 24 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/nfs_share/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/cifs_share/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/http_share/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/http_share_with_proxy_parameters/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/https_share/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/https_share_with_proxy_parameters/molecule.yml:(and 1 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_server_powerstate/molecule/default/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/default/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/import_buffer_xml/prepare.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/import_buffer_json/prepare.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152150/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152120/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152146/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152148/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152149/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/default/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152147/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_firmware/molecule/negative/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_firmware/molecule/default/molecule.yml 2 packages and 0 specfiles checked; 0 errors, 14 warnings, 7 filtered, 0 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "ansible-collection-dellemc-openmanage". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://raw.githubusercontent.com/dell/dellemc-openmanage-ansible-modules/v9.3.0/galaxy.yml : CHECKSUM(SHA256) this package : 2d16a9688e7cc27bcbaba72205c56e7b880b1644ed20ad2db19e46ba2cb397d7 CHECKSUM(SHA256) upstream package : 2d16a9688e7cc27bcbaba72205c56e7b880b1644ed20ad2db19e46ba2cb397d7 https://github.com/dell/dellemc-openmanage-ansible-modules/releases/download/v9.3.0/dellemc-openmanage-9.3.0.tar.gz.sign : CHECKSUM(SHA256) this package : 0e83902dba7db3eabfb5deff729d44e0343bccaa12e61afbfd76c4f449ae3fe0 CHECKSUM(SHA256) upstream package : 0e83902dba7db3eabfb5deff729d44e0343bccaa12e61afbfd76c4f449ae3fe0 https://github.com/dell/dellemc-openmanage-ansible-modules/releases/download/v9.3.0/dellemc-openmanage-9.3.0.tar.gz : CHECKSUM(SHA256) this package : 7bf1471720d43e929da524758cdf5ad70dbcc8e402edf111ef41d7747dc56110 CHECKSUM(SHA256) upstream package : 7bf1471720d43e929da524758cdf5ad70dbcc8e402edf111ef41d7747dc56110 Requires -------- ansible-collection-dellemc-openmanage (rpmlib, GLIBC filtered): (ansible-core or (ansible < 2.10.0 with ansible >= 2.9.10)) ansible-collection(ansible.utils) ansible-collection(ansible.windows) isomd5sum python3dist(netaddr) python3dist(omsdk) syslinux wget xorriso Provides -------- ansible-collection-dellemc-openmanage: ansible-collection(dellemc.openmanage) ansible-collection-dellemc-openmanage Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ansible-collection-dellemc-openmanage --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, SugarActivity, C/C++, Python, PHP, Perl, Ocaml, fonts, Haskell, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2284297 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202284297%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
