https://bugzilla.redhat.com/show_bug.cgi?id=2313339 jandrlik <jandrlik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #21 from jandrlik <jandrlik@xxxxxxxxxx> --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jandrlik/2313339-adoptium-temurin- java-repository/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/yum.repos.d [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [-]: Sources contain only permissible code or content. -No sources. [-]: Package contains desktop file if it is a GUI application. -Not a GUI app. [-]: Development files must be in a -devel package -No development files. [-]: Package uses nothing in %doc for runtime. -No %doc used. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. -Package is not a rename of another package. [-]: Requires correct, justified where necessary. -No Requires. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. -No need for systemd. [x]: Package is not known to require an ExcludeArch tag. -Package is compatible with all arches. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. No upstream for this package. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. No sources for this package. [-]: Package should compile and build into binary rpms on all supported architectures. Noarch package, no binary outputs for this one. [-]: %check is present and all tests pass. It is just a repo addition package, no checks needed IMO. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: adoptium-temurin-java-repository-1-1.fc42.noarch.rpm adoptium-temurin-java-repository-1-1.fc42.src.rpm ================================================================================== rpmlint session starts ================================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmj7zspjt')] checks: 32, packages: 2 adoptium-temurin-java-repository.noarch: W: summary-ended-with-dot Fedora package repository files for yum and dnf along with gpg public keys. adoptium-temurin-java-repository.src: W: summary-ended-with-dot Fedora package repository files for yum and dnf along with gpg public keys. adoptium-temurin-java-repository.noarch: E: spelling-error ('dnf', 'Summary(en_US) dnf -> def, inf, DNA') adoptium-temurin-java-repository.noarch: E: spelling-error ('gpg', 'Summary(en_US) gpg -> pg, gig, gag') adoptium-temurin-java-repository.src: E: spelling-error ('dnf', 'Summary(en_US) dnf -> def, inf, DNA') adoptium-temurin-java-repository.src: E: spelling-error ('gpg', 'Summary(en_US) gpg -> pg, gig, gag') adoptium-temurin-java-repository.noarch: W: only-non-binary-in-usr-lib adoptium-temurin-java-repository.noarch: W: non-conffile-in-etc /etc/yum.repos.d/adoptium-temurin-java-repository.repo adoptium-temurin-java-repository.noarch: W: no-documentation adoptium-temurin-java-repository.spec:16: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 1) ============================================= 2 packages and 0 specfiles checked; 4 errors, 6 warnings, 8 filtered, 4 badness; has taken 0.2 s ============================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 adoptium-temurin-java-repository.noarch: W: summary-ended-with-dot Fedora package repository files for yum and dnf along with gpg public keys. adoptium-temurin-java-repository.noarch: E: spelling-error ('dnf', 'Summary(en_US) dnf -> def, inf, DNA') adoptium-temurin-java-repository.noarch: E: spelling-error ('gpg', 'Summary(en_US) gpg -> pg, gig, gag') adoptium-temurin-java-repository.noarch: W: only-non-binary-in-usr-lib adoptium-temurin-java-repository.noarch: W: non-conffile-in-etc /etc/yum.repos.d/adoptium-temurin-java-repository.repo adoptium-temurin-java-repository.noarch: W: no-documentation 1 packages and 0 specfiles checked; 2 errors, 4 warnings, 3 filtered, 2 badness; has taken 0.1 s Requires -------- adoptium-temurin-java-repository (rpmlib, GLIBC filtered): fedora-third-party Provides -------- adoptium-temurin-java-repository: adoptium-temurin-java-repository Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2313339 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, R, C/C++, Java, fonts, PHP, Haskell, SugarActivity, Ocaml, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313339 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313339%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
