https://bugzilla.redhat.com/show_bug.cgi?id=2316537 Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #15 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- (In reply to Tom.Rix from comment #12) > Spec URL: https://trix.fedorapeople.org/hiprt.spec > SRPM URL: https://trix.fedorapeople.org/hiprt-2.4-1.6b6daf9.fc42.src.rpm > > For the addition of clang, which i believe is a false positive. > clang comes from comgr-devel -> clang-devel -> clang Yes, it is indeed a false positive upon verification. Maybe filing a bug report to rpmlint to resolve that particular issue. Back to the review, one small details is to add a comment for each patch according to https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ preferably after importing the source rpm. However, based on the criteria adhering to the packaging guideline, this package is ready for submission in the repository. APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2316537 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316537%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
