https://bugzilla.redhat.com/show_bug.cgi?id=2316806 Jeremy Linton <jeremy.linton@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jeremy.linton@arm | |.com) | --- Comment #9 from Jeremy Linton <jeremy.linton@xxxxxxx> --- Its looking pretty good, but i don't see: 1) Should probably have a pkgconf .pc file in -devel? This is helpful since the include directories now need to be explicitly overwritten by users of the library since its not directly in /usr/include. 2) The excludearch bugs/comment. Ex open two bugs. One against: https://bugzilla.redhat.com/show_bug.cgi?id=238953 and another against: https://bugzilla.redhat.com/show_bug.cgi?id=485231 Note the bug numbers in the ExcludeArch comment in the .spec file. 3) And sorry about this one, but I was thinking about this after I posted the review template, but the OpenCL, Half, etc headers being shipped in the -devel package here should probably be stripped since they duplicate existing packages in fedora, and unless it won't build/work without them this probably partially falls under " Package contains no bundled libraries without FPC exception." See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316806%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
