https://bugzilla.redhat.com/show_bug.cgi?id=2317585 Jens Petersen <petersen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |petersen@xxxxxxxxxx --- Comment #16 from Jens Petersen <petersen@xxxxxxxxxx> --- I made a rough package, for copr starting some weeks ago: see https://copr-dist-git.fedorainfracloud.org/cgit/petersen/ramalama/python-ramalama.git/tree/python-ramalama.spec (updated to 0.0.19 now) it uses the forge macros, which you could also consider. Though with the upstream tagged releases now that is optional I would say. Might still be worth looking over or rather comparing the spec files anyway. I don't like the unnamed github tarball: Source0: %{source_url}/archive/refs/tags/v%{version}.tar.gz If you don't want to use the forge macros: Source0: %{forgesource} then better to use the de facto standard url suffix, like this: Source0: %{source_url}/archive/refs/tags/v%{version}.tar.gz#/%{pypi_name}-%{version}.tar.gz to get a named tarball (why github didn't do this by default is beyond me but anyway I guess that ship is long sailed). I believe `%global debug_package %{nil}` is also redundant and hence can be dropped? Is the intention to maintain this package as dist-source? (Otherwise the comment about the upstream spec file should be removed.) It could be nice to have the review changelog entries in the spec file. I couldn't get the bash completions to do anything yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2317585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
