https://bugzilla.redhat.com/show_bug.cgi?id=2316282 --- Comment #13 from Cristian Le <fedora@xxxxxxxxx> --- So far only small changes remain: - `BSD-3-Clause-Clear` -> `LicenseRef-BSD-3-Clause-Clear-WITH-AdditionRef-AOMPL-1.0` - See the license breakdown in upstream [1], those licenses should also be included - `valgrind-devel` is a development tool like a linter, it should not be used - The `ENABLE_AVX512` option is actually wrongly defined in the CMakeLists.txt, but also supporting a subset of architectures is more complicated, I would need some guidance on this subject as well on how to review this. - For now move `SVT_AV1_PGO` to a TODO? The implication of it seem quite complicated, and maybe it would be good to investigate what it does and how much of an impact it has - Despite upstream documentation, `BUILD_DEC` is not really used anywhere, can remove it - I would recommend adding a few TODOs on things that seem interesting to investigate like: `ENABLE_AVX512`, `SVT_AV1_PGO`, `REPRODUCIBLE_BUILDS` + `EXCLUDE_HASH` (you can find some of them by running `ccmake -B build`, but beware it is not always comprehensive) - Use a `bcond_check` and wrap the `%check` section to ignore it for now, and comment about the failing tests that need to be investigated - Does `svt-av1`/`svt-av1-psy` work without decoder parts? Maybe some additional `Provides` would be in order? Need someone more familiar with the whole project to comment on this part [1]: https://src.fedoraproject.org/rpms/svt-av1/blob/rawhide/f/svt-av1.spec#_12-19 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316282 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316282%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
