https://bugzilla.redhat.com/show_bug.cgi?id=2316473 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #18 from Cristian Le <fedora@xxxxxxxxx> --- Final 3 blocking change requests: - Don't add a new line between `%description` and the body. Try to run `rpm -qi ...` you will see that it is being included there. Generally it is common design to remove the other separations between section headers (%build, %install, etc.) and their body below - Seems upstream does not include `ctest` tests. In the meantime run it manually via `%{__cmake_builddir}/unittests/safestring_test` (you may need to prefix it with `./`?) - Add a `^` separator between the version `1.2.0` and the snapshotdate [1]. Also using a macro for it would be preferred Other than that it looks fine. Various issues with the project itself, e.g. the naming of the library, lack of `SOVERSION` etc. but I will pick those bones with upstream directly personally since backwards compatibility is tricky. [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316473 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316473%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
