Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: event-compat-sysv - sysVinit compatibility for upstart https://bugzilla.redhat.com/show_bug.cgi?id=429416 notting@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|431106 | AssignedTo|nobody@xxxxxxxxxxxxxxxxx |notting@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From notting@xxxxxxxxxx 2008-01-31 15:42 EST ------- MUST items: - Package meets naming guidelines - OK - Spec file matches base package name. - *** - Spec has consistant macro usage. - OK - Meets Packaging Guidelines. - *** - License - *** - License field in spec matches - *** - License file included in package - *** - Spec in American English - OK - Spec is legible. - OK - Sources match upstream md5sum: 22d66ef8bc9d167eb822bbfecb584107 - OK - Package needs ExcludeArch - see note about buildarch below - BuildRequires correct - OK - Package has %defattr and permissions on files is good. - OK - Package has a correct %clean section. - OK - Package has correct buildroot - OK %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - OK - Doc subpackage needed/used. - N/A - Package compiles and builds on at least one arch. - OK - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. - OK - Package owns all the directories it creates. - OK - No rpmlint output. *** - final provides and requires are sane: *** SHOULD Items: - Should build in mock. - OK (tested on x86_64) - Should build on all supported archs - it's noarch - Should function as described. **** - Should have dist tag - OK - Should package latest version - OK Issues: 1) Doesn't match upstream tarball; then again, 'example-jobs' is a pretty awful name, so this should probably be ignored. Then again, this maybe should move to initscripts at some point? 2) Package should have 'BuildArchitecture: noarch' and be built as a noarch package - there's nothing arch specific about it, AFAICT 3) There's no license information in the source at all. Probably should be cleaned up somewhere. 4) Explicit Provides for SysVinit seems wrong, especially w/o an obsolete. Need to figure out whether the obsolete goes here or in upstart. 5) More rpmlint: event-compat-sysv.noarch: W: non-conffile-in-etc /etc/event.d/rc2 event-compat-sysv.noarch: W: non-conffile-in-etc /etc/event.d/rc3 event-compat-sysv.noarch: W: non-conffile-in-etc /etc/event.d/rc0 ... Possibly should be marked %config(noreplace), as the admin may want to customize these. Note: %config(noreplace) makes upgrading *very* hard in the case of event file format changes. 6) See bug 431120. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review