https://bugzilla.redhat.com/show_bug.cgi?id=2277528 --- Comment #10 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'MIT AND Minpack AND LicenseRef-Fedora- UltraPermissive AND HIDAPI AND ((MIT OR X11) OR BSD 3-Clause OR GPL-1.0-or-later) AND (MIT AND (MIT OR X11) OR BSD 3-Clause) AND (MIT AND (MIT OR X11)) AND Zlib'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Approved per https://docs.fedoraproject.org/en-US/packaging-guidelines/Unversioned_shared_objects/ [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "GNU General Public License, Version 3", "zlib License", "Apache License 1.1", "MIT License and/or The Unlicense", "BSD 2-Clause License". 526 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/libsurvive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 33413 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- libsurvive: /usr/lib64/libsurvive/plugins/disambiguator_statebased.so libsurvive: /usr/lib64/libsurvive/plugins/driver_dummy.so libsurvive: /usr/lib64/libsurvive/plugins/driver_global_scene_solver.so libsurvive: /usr/lib64/libsurvive/plugins/driver_playback.so libsurvive: /usr/lib64/libsurvive/plugins/driver_simulator.so libsurvive: /usr/lib64/libsurvive/plugins/driver_udp.so libsurvive: /usr/lib64/libsurvive/plugins/driver_usbmon.so libsurvive: /usr/lib64/libsurvive/plugins/driver_vive.so libsurvive: /usr/lib64/libsurvive/plugins/poser_barycentric_svd.so libsurvive: /usr/lib64/libsurvive/plugins/poser_dummy.so libsurvive: /usr/lib64/libsurvive/plugins/poser_kalman_only.so libsurvive: /usr/lib64/libsurvive/plugins/poser_mpfit.so Source checksums ---------------- https://github.com/jdavidberger/libsurvive-extras-data/archive/3476af66c488b029e04c74fbb1b57f3b7acb9eb7/libsurvive-extras-data-3476af66c488b029e04c74fbb1b57f3b7acb9eb7.tar.gz : CHECKSUM(SHA256) this package : bb45aef8ae57dafd3fc84f89374af7eb0dc9cb15b1e2c24692e78c03a567fc67 CHECKSUM(SHA256) upstream package : bb45aef8ae57dafd3fc84f89374af7eb0dc9cb15b1e2c24692e78c03a567fc67 https://github.com/cntools/cnmatrix/archive/5936c62511305227fbd59b2d5a43aaf89ec3a0b6/cnmatrix-5936c62511305227fbd59b2d5a43aaf89ec3a0b6.tar.gz : CHECKSUM(SHA256) this package : e4f1c776c5fbf04374727b6b1c6c32f7226db35fde480468f857df5b6d543f81 CHECKSUM(SHA256) upstream package : e4f1c776c5fbf04374727b6b1c6c32f7226db35fde480468f857df5b6d543f81 https://github.com/cntools/cnkalman/archive/6b350314225e28d2e4e8daad7d2971d22386f76f/cnkalman-6b350314225e28d2e4e8daad7d2971d22386f76f.tar.gz : CHECKSUM(SHA256) this package : e7082c497fb9c76b79f781b3b15147c12a122026a1f3f83a44605132c2766093 CHECKSUM(SHA256) upstream package : e7082c497fb9c76b79f781b3b15147c12a122026a1f3f83a44605132c2766093 https://github.com/cntools/libsurvive/archive/4fb6d888d0277a8a3ba725e63707434d80ecdb2a/libsurvive-4fb6d888d0277a8a3ba725e63707434d80ecdb2a.tar.gz : CHECKSUM(SHA256) this package : 51280535c8edaa367ec8e8e681022e55a6db13b3bf143bc3005b4d25d21105de CHECKSUM(SHA256) upstream package : 51280535c8edaa367ec8e8e681022e55a6db13b3bf143bc3005b4d25d21105de Requires -------- libsurvive (rpmlib, GLIBC filtered): /usr/bin/bash libc.so.6()(64bit) libm.so.6()(64bit) libpcap.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsurvive.so.0()(64bit) libusb-1.0.so.0()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.7.1)(64bit) rtld(GNU_HASH) systemd-udev libsurvive-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libc.so.6()(64bit) libsurvive(x86-64) libsurvive.so.0()(64bit) rtld(GNU_HASH) libsurvive-debuginfo (rpmlib, GLIBC filtered): libsurvive-debugsource (rpmlib, GLIBC filtered): Provides -------- libsurvive: bundled(CNFG) bundled(CNFG3D) bundled(cnkalman) bundled(cnmatrix) bundled(crc32) bundled(hidapi) bundled(jsmn) bundled(linmath) bundled(mpfit) bundled(zlib) libsurvive libsurvive(x86-64) libsurvive.so.0()(64bit) libsurvive-devel: libsurvive-devel libsurvive-devel(x86-64) pkgconfig(survive) libsurvive-debuginfo: debuginfo(build-id) libsurvive-debuginfo libsurvive-debuginfo(x86-64) libsurvive.so.0.3-1.01^20240510git4fb6d88-1.fc42.x86_64.debug()(64bit) libsurvive-debugsource: libsurvive-debugsource libsurvive-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n libsurvive-1.01^20240510git4fb6d88-1.fc42.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, Java, PHP, Ocaml, R, fonts, SugarActivity, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277528 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277528%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
