[Bug 2316327] Review Request: opa-fm - Cornelis Networks Fabric Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2316327



--- Comment #6 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
You can manage the spec file in a git repository, but the name should just be 
opa-fm.spec not opa-fm.fedora.spec, perhaps put in a subdirectory
packaging>fedora>opa-fm.spec

For unowned directories see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_forgetting_to_include_a_toplevel_directory

For
/usr/share/opa-fm
add
%dir %{_datadir}/opa-fm

For
/usr/lib/opa-fm/bin
/usr/lib/opa-fm
/usr/lib/opa-fm/runtime

These should likely be in /usr/lib64
You would then add
%dir %{_libdir}/opa-fm
%dir %{_libdir}/opa-fm/bin
%dir %{_libdir}/opa-fm/runtime

Globbing is also generally best avoided:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2316327

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316327%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux