https://bugzilla.redhat.com/show_bug.cgi?id=2316944 --- Comment #2 from Jeremy Linton <jeremy.linton@xxxxxxx> --- So, two comments/questions before I 'fail' a couple of sections. First, SimpleCrypt, is only being used for the 'jammer' password option. Simply removing that option solves a bunch of the BSD/something license issues, right? S why not just remove it as an option, plain text, user entered, or kwallet gives the gammut of 'don't care', 'don't trust' and 'reasonable option'. Then there isn't the whole "how legitimate is it to update the license" "why doesn't the license file call out BSD" "Without the update the license isn't valid for fedora" issues. Secondly, the .so plugins dependencies aren't being picked up by the automatic library dependency logic and that results in missing dependencies. I think those should be manually requires/recommended because it possible some of them won't be installed (ex:kf5-kwallet). Other than that, at the moment it looks reasonable when checked against the lmdbal library. I can/will post the full review template if you don't see this/fix it in the next day or so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2316944 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316944%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
