https://bugzilla.redhat.com/show_bug.cgi?id=2317589 --- Comment #7 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Ben Beasley from comment #5) > The package is APPROVED, but please see the two suggestions, below: Thank you. > - Consider proposing to upstream that they remove the version bound on the uv > dependency. > > uv<1,>=0.4.7 > > According to semantic versioning, uv 1.0 is no more likely to contain > breaking changes than uv 0.5 is. Furthermore, the uv pip / uv venv > functionality that this package uses has not seen intentional breaking > changes since the initial public release of uv, and I would not expect > nontrivial breaking changes in these areas in the future since the > interfaces > are based so closely on existing tools. I know the upstream of tox loves pinning and if the time comes for uv 1, I can sed this one out. The upstream discussion is not worth it. > - Please consider changing > > %pyproject_save_files tox_uv > > to > > %pyproject_save_files -l tox_uv > > to guard against accidental loss of the properly-indicated packaged license > file in a future update. Will do, this was an oversight on my side. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2317589 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317589%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
