https://bugzilla.redhat.com/show_bug.cgi?id=2315523 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ CC| |fedora@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxx --- Comment #3 from Cristian Le <fedora@xxxxxxxxx> --- LGTM. This is a straightforward rust2rpm, and all seems fine. My additional suggestion is to add a blank `rust2rpm.toml` just to indicate that you've used all default values. Also could you mark the bugzilla bug that requires this package that is referenced in: > The new version 1.2.20 of existing nispor rpm introduced new dependency on rust crate -- wl-nl80211. Hence we need introduce its crate into fedora (Using Fabio's review template) === Package was generated with rust2rpm, simplifying the review. ✅❌❓🫤 ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (Upstream doesn't have any tests, other than examples compiling I guess) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2315523 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202315523%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
