https://bugzilla.redhat.com/show_bug.cgi?id=2316473 --- Comment #3 from solomoncyj@xxxxxxxxx --- This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: safestringlib : /usr/include/safe_lib.h safestringlib : /usr/include/safe_lib_errno.h safestringlib : /usr/include/safe_mem_lib.h safestringlib : /usr/include/safe_str_lib.h safestringlib : /usr/include/safe_types.h safestringlib : /usr/include/snprintf_s.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 14 files have unknown license. Detailed output of licensecheck in /home/solomoncyj/Downloads/safestring/review- safestringlib/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include(filesystem) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: safestringlib-1.2.020240520^fd159bf-1.fc42.x86_64.rpm safestringlib-1.2.020240520^fd159bf-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2ec66qak')] checks: 32, packages: 2 safestringlib.src: W: summary-not-capitalized routines for safe string operations safestringlib.x86_64: W: summary-not-capitalized routines for safe string operations safestringlib.x86_64: E: standard-dir-owned-by-package /usr/include safestringlib.src: E: spelling-error ('strcpy', '%description -l en_US strcpy -> stripy') safestringlib.src: E: spelling-error ('memcpy', '%description -l en_US memcpy -> memory') safestringlib.x86_64: E: spelling-error ('strcpy', '%description -l en_US strcpy -> stripy') safestringlib.x86_64: E: spelling-error ('memcpy', '%description -l en_US memcpy -> memory') safestringlib.x86_64: W: no-documentation safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_lib.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_lib_errno.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_mem_lib.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_str_lib.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_types.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/snprintf_s.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/lib/libsafestring_shared.so 2 packages and 0 specfiles checked; 5 errors, 10 warnings, 23 filtered, 5 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: safestringlib-debuginfo-1.2.020240520^fd159bf-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp2gj669j')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 safestringlib.x86_64: W: summary-not-capitalized routines for safe string operations safestringlib.x86_64: E: standard-dir-owned-by-package /usr/include safestringlib.x86_64: E: spelling-error ('strcpy', '%description -l en_US strcpy -> stripy') safestringlib.x86_64: E: spelling-error ('memcpy', '%description -l en_US memcpy -> memory') safestringlib.x86_64: W: no-documentation safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_lib.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_lib_errno.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_mem_lib.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_str_lib.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/safe_types.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/include/snprintf_s.h safestringlib.x86_64: W: devel-file-in-non-devel-package /usr/lib/libsafestring_shared.so 2 packages and 0 specfiles checked; 3 errors, 9 warnings, 24 filtered, 3 badness; has taken 0.5 s Unversioned so-files -------------------- safestringlib: /usr/lib/libsafestring_shared.so Source checksums ---------------- https://github.com/intel/safestringlib/archive/refs/heads/master.zip : CHECKSUM(SHA256) this package : c2b2417f76c081e0716a80582b06592e253f8317f1b88cb61fe6f15aa3e57349 CHECKSUM(SHA256) upstream package : c2b2417f76c081e0716a80582b06592e253f8317f1b88cb61fe6f15aa3e57349 Requires -------- safestringlib (rpmlib, GLIBC filtered): libc.so.6()(64bit) libsafestring_shared.so.1.2.0()(64bit) rtld(GNU_HASH) Provides -------- safestringlib: libsafestring_shared.so.1.2.0()(64bit) safestringlib safestringlib(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n safestringlib Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, SugarActivity, fonts, Haskell, R, PHP, Ocaml, Java, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316473 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316473%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
