https://bugzilla.redhat.com/show_bug.cgi?id=2316470 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@xxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |ngompa13@xxxxxxxxx Doc Type|--- |If docs needed, set a value Status|NEW |POST --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package follows Fedora Packaging Guidelines (mostly) * Package builds and installs * Package licensing is correct and license data is captured correctly * No serious issues from rpmlint Issues to fix on import: - Globbing for libraries isn't quite right, you should use ".so.2{,.*}" to ensure things like ".so.20" don't match. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Otherwise... PACKAGE APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316470 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316470%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
