https://bugzilla.redhat.com/show_bug.cgi?id=2316282 --- Comment #8 from Cristian Le <fedora@xxxxxxxxx> --- Similar to [1] it seems there are more complicated license breakdowns. Hopefully licensecheck can help navigate through them. Breakdown of the `third_party` stuff: - `aom/inc/aom`: Used only in tests. Should be available in Fedora through `aom` [2]. Delete if running the tests proves too hard, otherwise indicate in the SourceLicense breakdown or comments. - `aom_dsp`: Same as above, but upstream does not seem to expose it. - `cpuinfo`: Available in fedora build supports linking to it. Please delete it and use `-DUSE_EXTERNAL_CPUINFO=ON`. - `fastfeat`: Dead project and there seems to be an alternative code-generated version [3]. For now though, just `Provides: bundled()` it and include it's license. - `googletest`: Available in Fedora. Needs some patching to remove the `third_party/googletest` references and replace them with `find_package(GTest)`, `target_link_libraries(GTest::gtest GTest::gtest_main)` and a few other stuff. Alternatively open an issue and ask them to support linking against system `gtest` (or better have `FetchContent(FIND_PACKAGE_ARGS)` support). - `safestringlib`: Available upstream project [4] but not packaged to Fedora. Please open an issue in either project to request supporting that. In any case the license breakdown should indicate the `third_party` stuff, either inside the `License` field or `SourceLicense` field (for the case of `googletest` which is not packaged), and appropriate `Provides: bundled()` should be added. [1]: https://src.fedoraproject.org/rpms/svt-av1/blob/rawhide/f/svt-av1.spec [2]: https://src.fedoraproject.org/rpms/aom [3]: https://github.com/edrosten/fast-C-src/issues/3 [4]: https://github.com/intel/safestringlib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2316282 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316282%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
