https://bugzilla.redhat.com/show_bug.cgi?id=2316282 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Cristian Le <fedora@xxxxxxxxx> --- - Please add `-DUSE_EXTERNAL_CPUINFO=ON` and delete `third_party/cpuinfo` - Delete all `third_party` actually. We need to go over those files to make sure there are no unpackageable files that we need to sanitize first - Enable the unit tests (`-DBUILD_TESTING=ON`) - The `HAVE_ARM_PLATFORM` section will be very tricky to handle for `aarch64` builders (all of the `ENABLE_NEON` and similar options). I don't have the expertise there, maybe you can ping this in devel to get a second pair of eyes. - I think `EXCLUDE_HASH` (and by extension `REPRODUCIBLE_BUILDS`) should be `ON` - Unconditional `add_subdirectory(third_party/fastfeat)` is problematic :(. It's a dead project though, so maybe you can just use `Provides: bundled(fastfeat)` in this case. - I need to go through the build 3-4 more times, there are so many more weird stuff to review in there. (Oh god I hate the build system for this project as well) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316282 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316282%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
