[Bug 409511] Review Request: libmlx4 - Mellanox ConnectX InfiniBand HCA Userspace Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmlx4 - Mellanox ConnectX InfiniBand HCA Userspace Driver


https://bugzilla.redhat.com/show_bug.cgi?id=409511


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs@xxxxxxxxxxx  2008-01-31 00:22 EST -------
This picked up an additional rpmlint complaint, as expected:
  libmlx4.x86_64: W: non-conffile-in-etc /etc/libibverbs.d/mlx4.driver
but that's OK.

About the .so file, it is somewhat suboptimal, but this wouldn't be the first
package in the distro to do this and you do have a reasonable point about being
able to have specifically optimized versions without duplicating all of that
logic from the loader.  So I guess there's not much to do.

Outside of that, everything looks good to me.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]